[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451939#comment-17451939
]
Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 12/1/21, 5:43 PM:
---------------------------------------------------------------------------
Moving the ticket to "In Review" as [~dcapwell] is already looking into it.
Also, for visibility and context as it seems I missed in my summary - there is
a separate ticket linked to this one(CASSANDRA-9691) which was mentioning
liberating metrics and JMX from units or just moving to lowest unit at least. I
left this part to be handled there but I forgot to mention it in my summary.
Apologize for that
My thought was currently to leave the JMX and metrics for now and assume the
old units are in place but [~dcapwell] is right we need at least to verify and
convert if needed that in Config the old unit was used with the new custom
types and we didn't use something different as this can be a mess if we leave
it to people and reading docs. Something similar will also be needed for VTs
where we will have to check the Converter in the new @Replaces annotation.
There was idea for getting the VT backward compatibility out until we figure
out how we are going to handle the VT as there is ongoing discussion around
that, I will leave this now aside for a moment until we clear a bit the
discussion. CC [~blerer] as I know he is working on a patch for CASSANDRA-15254
Also, I will be looking again into the ccm issue in the afternoon.
was (Author: e.dimitrova):
Moving the ticket to "In Review" as [~dcapwell] is already looking into it.
Also, for visibility and context as it seems I missed in my summary - there is
a separate ticket linked to this one(CASSANDRA-9691) which was mentioning
liberating metrics and JMX from units or just moving to lowest unit at least. I
left this part to be handled there but I forgot to mention it in my summary.
Apologize for that
My thought was currently to leave the JMX and metrics for now and assume the
old units are in place but [~dcapwell] is right we need at least to verify and
convert if needed that in Config the old unit was used with the new custom
types and we didn't use something different as this can be a mess if we live it
to people and reading docs. Something similar will also be needed for VTs where
we will have to check the Converter in the new @Replaces annotation. There was
idea for getting the VT backward compatibility out until we figure out how we
are going to handle the VT as there is ongoing discussion around that, I will
leave this now aside for a moment until we clear a bit the discussion. CC
[~blerer] as I know he is working on a patch for CASSANDRA-15254
Also, I will be looking again into the ccm issue in the afternoon.
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
