[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452661#comment-17452661
]
Ekaterina Dimitrova edited comment on CASSANDRA-15234 at 12/2/21, 11:47 PM:
----------------------------------------------------------------------------
Short update:
- I figured out what needs to be done in order to be able to test with our own
CCM branch - ticket to update our docs opened CASSANDRA-17182.
- I was also thinking of adding a test to the ccm tests but it seems they are
not run in CI, not sure what is the story there. ([~mck], any ideas?)
- Almost all tests pass now, it seems I have an issue with the assert warnings
only(a few Python DTests failed), I have to correct the string pattern used. I
did it
[here|https://github.com/apache/cassandra-dtest/pull/169/commits/7c417847092524d46de9e03d11d6acc63159e2dd]
but I haven't run whole CI for this now. [Java8
CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1239/workflows/345d82ca-1e2a-4db9-b660-a88324793a40]
| [Java11 CI
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1239/workflows/d0f8f584-ede1-42f1-96ad-9fbc2d981a56].
This branch was not rebased in the past two weeks so some of the test fixes
are not applied.
- I will do the JMX change next week in a new commit, it also shouldn't bother
any reviews to happen in the meantime if/when people are available. I know
[~dcapwell] and [~blerer] are busy and also holidays are approaching.
was (Author: e.dimitrova):
Short update:
- I figured out what needs to be done in order to be able to test with our own
CCM branch - ticket to update our docs opened CASSANDRA-17182.
- I was also thinking of adding a test to the ccm tests but it seems they are
not run in CI, not sure what is the story there. ([~mck], any ideas?)
- Almost all tests pass now, it seems I have an issue with the assert warnings
only, I have to correct the pattern. I did it
[here|https://github.com/apache/cassandra-dtest/pull/169/commits/7c417847092524d46de9e03d11d6acc63159e2dd]
but I don't think I haven't run whole CI for this. [Java8
CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1239/workflows/345d82ca-1e2a-4db9-b660-a88324793a40]
| [Java11
CIhttps://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1239/workflows/d0f8f584-ede1-42f1-96ad-9fbc2d981a56].
This branch was not rebased in the past two weeks so some of the test fixes
are no applied.
- I will do the JMX change next week in a new commit, it also shouldn't bother
any reviews to happen in the meantime if/when people are available. I know
[~dcapwell] and [~blerer] are busy and also holidays are approaching.
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
