[
https://issues.apache.org/jira/browse/CASSANDRA-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454712#comment-17454712
]
Bartlomiej commented on CASSANDRA-17181:
----------------------------------------
Hi,
I created patch following steps from
[https://cassandra.apache.org/_/development/patches.html]
I looked if I can remove properties you pointed, so it is a bit simpler now. I
run tests I modified (all passed). I wondered about TableMatadata.toCqlString
because it also is used once with (true, true true) passed, but I was not sure
I should touch it :)
I also run the *ant test* but I took almost 3h to finish and there was some
timeout :) so I am not sure about testing phase of this change, any
recommendations ?
thanks !
> SchemaCQLHelperTest methods can be simplified
> ---------------------------------------------
>
> Key: CASSANDRA-17181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17181
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Snapshots
> Reporter: Benjamin Lerer
> Assignee: Bartlomiej
> Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.1
>
> Attachments: CASSANDRA-17181-4.0.patch
>
>
> {{SchemaCQLHelperTest}} is used during a snapshot to generate the
> {{schema.cql}} file. The methods accept the following paramaters:
> {{includeDroppedColumns}}, {{internals}} and {{ifNotExists}}.
> Those parameters are in practice always set to true by the calling code and
> therefore can be removed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
