[ https://issues.apache.org/jira/browse/CASSANDRA-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459989#comment-17459989 ]
Benjamin Lerer commented on CASSANDRA-17181: -------------------------------------------- That look good to me :-) [CI run|https://app.circleci.com/pipelines/github/blerer/cassandra/252/workflows/00138f7d-c813-47fa-9b0d-284a059c8d22] > SchemaCQLHelperTest methods can be simplified > --------------------------------------------- > > Key: CASSANDRA-17181 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17181 > Project: Cassandra > Issue Type: Improvement > Components: Local/Snapshots > Reporter: Benjamin Lerer > Assignee: Bartlomiej > Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 4.0.x, 4.x > > Attachments: CASSANDRA-17181-4.0.patch > > > {{SchemaCQLHelperTest}} is used during a snapshot to generate the > {{schema.cql}} file. The methods accept the following paramaters: > {{includeDroppedColumns}}, {{internals}} and {{ifNotExists}}. > Those parameters are in practice always set to true by the calling code and > therefore can be removed. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org