[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460231#comment-17460231
]
Ekaterina Dimitrova commented on CASSANDRA-15234:
-------------------------------------------------
Thank you [~maedhroz]
I made all changes as per the review comments and our discussions. I also left
responses on the PR. I have three commits on
[this|https://github.com/ekaterinadimitrova2/cassandra/pull/191/files] new PR,
as we talked (The old PR stays there, nothing added, nothing squashed; kept for
reference) Next round of review on the [new
|https://github.com/ekaterinadimitrova2/cassandra/pull/191/files] PR, the
following commits:
* [the custom types and the related
tests|https://github.com/ekaterinadimitrova2/cassandra/pull/191/commits/c5b19d441949a4bbf0a4395517f8f637b9ee1ddf].
All tests pass
* [The annotations and
converters|https://github.com/ekaterinadimitrova2/cassandra/pull/191/commits/4fda1efee2cb9e066661982f79d1aa99ad8fbf8b]
for backward compatibility. I [ran
|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1253/workflows/864beb33-9051-4ef7-a96d-4e235fa96e4e]
the test suite to ensure any changes in the YAML loader didn't break anything.
From what I see the only failures are known ones which after rebase of the
patch should go away, most of them.
* [The big change
|https://github.com/ekaterinadimitrova2/cassandra/pull/191/commits/6a4cf1d5925da154fd39c35e367fb1aa0f447ca3]-
all the parameters plus adding backward compatibility for virtual tables. [CI
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1255/workflows/89b0d74c-f745-436a-b2bb-bc7b5ea721e6]
Java 8 (I will run again also Java 11 later but there was no reason to waste
resources now). The only related to this patch failure is the one of
_test_sstablelevelreset ._ I have to adjust the warning pattern in the dtest
repo.
Side Note: There are two circle ci related commits for testing purposes. Please
ignore them at the end.
I haven't touched the docs as they will have to be reworked after the migration
to adoc.
JMX methods convert to the old unit is in there but I will add new JMX method
in a separate commit. (There is another ticket linked to this one for that but
there was a discussion better to add them here) This doesn't stop the rest of
the work from being revised in the meantime.
I have to add also that warning we discussed in case some parameters are set
more than once in cassandra.yaml. I will do it in a separate commit.
After we confirm the current work, I will do new rebase and change any new
parameters in trunk to the new format (we still don't have alpha version so it
is safe to just change the names and types and no backward compatibility is
needed).
Order of commits for now should be:
1) Cassandra repo [(the custom types and related
tests)|https://github.com/ekaterinadimitrova2/cassandra/pull/191/commits/c5b19d441949a4bbf0a4395517f8f637b9ee1ddf]
2) Cassandra repo ([The backward compatibility framework
|https://github.com/ekaterinadimitrova2/cassandra/pull/191/commits/4fda1efee2cb9e066661982f79d1aa99ad8fbf8b])
3) CCM patch
4) dtest patch
5) The [big change of
parameters|https://github.com/ekaterinadimitrova2/cassandra/pull/191/commits/6a4cf1d5925da154fd39c35e367fb1aa0f447ca3]
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
