[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479794#comment-17479794
]
Ekaterina Dimitrova commented on CASSANDRA-15234:
-------------------------------------------------
The CI lgtm, there are all known failures. The byteman issues appear again but
they turned to be general problem with CircleCI. There is already a ticket for
investigation.
One thing on my mind is - there was a question whether we should use "fail" or
"abort" if I am not mistaken. I noticed that only recently "abort" was
introduced, "fail" is widely used in our config. I would suggest to stick to
"fail" as it is already common for our users. Of course, I will be happy to
hear if someone has a different perspective on this topic.
Also, my understanding is that [~dcapwell](from offline discussion) and
[~maedhroz] are done with their reviews. [~blerer] is swamped at the moment
but I want to thank him for all his support and feedback at the early stages.
My understanding is [~mck] is about to do a final review and then we can commit
when he is ready and of course, I address any potential concerns he might have.
I will also do another pass tomorrow as the patch is big and widely spread
around the codebase.
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
