[
https://issues.apache.org/jira/browse/CASSANDRA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479504#comment-17479504
]
Stefan Miklosovic edited comment on CASSANDRA-16956 at 1/20/22, 4:50 PM:
-------------------------------------------------------------------------
Fair enough. I still consider it to be a bug based on the fact that once we say
we do not support Windows on 4.0 a user can still run it. It is as if (this is
purely hypothetical example) we said that we do not support materialized views
but they are still there. My take on it is that if it is not supported it
should not be there. We have quite comprehensive test suite to make a fair
assumption that it has not broken anything.
But again, I can totally live with that code in 4.0. You guys are longer here
and decisions like these are not always black and white.
btw, the fact is that it will be still in 4.0.0 and if there is somebody who
absolutely wants to run (any) 4.0 on Windows, it will be possible. So us
removing it in 4.0.x is kind of useless anyway. So looking at it from this
perspective, I would go with your argument to NOT remove it. We basically do
not eliminate people to run 4.0 on Windows if they really want so it is already
"too late". We might as well just leave it there.
was (Author: smiklosovic):
Fair enough. I still consider it to be a bug based on the fact that once we say
we do not support Windows on 4.0 a user can still run it. It is as if (this is
purely hypothetical example) we said that we do not support materialized views
but they are still there. My take on it is that if it is not supported it
should not be there. We have quite comprehensive test suite to make a fair
assumption that it has not broken anything.
But again, I can totally live with that code in 4.0. You guys are longer here
and decisions like these are not always black and white.
> Remove windows-specific classes
> -------------------------------
>
> Key: CASSANDRA-16956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16956
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Brandon Williams
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc, signature.asc, signature.asc, signature.asc, signature.asc
>
>
> To continue the work CASSANDRA-16171 began, now that Windows support is no
> more there are some source files that can be removed.
> Just doing a naive grep on the source directory I see:
> {noformat}
> src/java/org/apache/cassandra/db/WindowsFailedSnapshotTracker.java
> src/java/org/apache/cassandra/utils/NativeLibraryWindows.java
> src/java/org/apache/cassandra/utils/WindowsTimer.java
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
