[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481295#comment-17481295
]
Andres de la Peña commented on CASSANDRA-17009:
-----------------------------------------------
The patch looks good to me, I have only left a few trivial suggestions on the
[~bereng]'s PR.
[Here|https://app.circleci.com/pipelines/github/adelapena/cassandra/1251/workflows/23420982-3892-4a77-a93c-c3c2cf7da317]
are a few runs of the new {{StandaloneVerifierOnSSTablesTest}} in the
multiplexer. I think we would need a PR for trunk with a CI run.
> Sstableverify unit test operate on SSTables
> -------------------------------------------
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
> Reporter: Brian Houser
> Assignee: Brian Houser
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
