[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481783#comment-17481783
]
Andres de la Peña commented on CASSANDRA-17009:
-----------------------------------------------
Great, both PRs look good to me, +1. I have left a couple of formatting nits
that can be addressed during commit.
Here are some additional multiplexer runs for the new
{{StandaloneVerifierOnSSTablesTest}}:
||branch||CI||
|[4.0|https://github.com/adelapena/cassandra/tree/17009-4.0-review]
|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1253/workflows/2c174af1-c2ec-4c20-bd73-2e32026eb1d8]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1253/workflows/26933022-7c32-426d-b064-2c572a6f2ac1]|
|[trunk|https://github.com/adelapena/cassandra/tree/17009-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1252/workflows/6e9b6d4b-d928-43c9-9cf3-97d7c8a4b733]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1252/workflows/4b376c0b-39e9-4ea6-81bf-d79291d1127c]|
> Sstableverify unit test operate on SSTables
> -------------------------------------------
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
> Reporter: Brian Houser
> Assignee: Brian Houser
> Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
