[ 
https://issues.apache.org/jira/browse/CASSANDRA-17543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521111#comment-17521111
 ] 

Andres de la Peña edited comment on CASSANDRA-17543 at 4/12/22 12:22 PM:
-------------------------------------------------------------------------

The {{ReadRepairQueryTypesTest}} test suite seems very stable on CircleCI, as 
it's shown by the success of these 1000-iteration runs:
||branch||CI||
|4.0|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1471/workflows/c183b8ac-4a34-4774-865e-4fe85f3aa191]
 
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1471/workflows/d5fd42da-098f-4752-8810-d1063a504850]|
|trunk|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1470/workflows/843f5ceb-f0f8-4b81-8a5d-61e333118ca6]
 
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1470/workflows/21f52bdc-9a1e-4eab-8ae2-e99721d24e57]|

However, it seems that a particularly slow run on Jenkins can hit the config 
limit defined by 
[{{test.distributed.timeout}}|https://github.com/apache/cassandra/blob/2fde9af74f12179fd8b3d592adc9a24d8b2d8f23/build.xml#L116].
 The reported run times for the the last Jenkins runs show great variability, 
with some runs being close to the limit:
||mm:ss||
|[09:26|https://ci-cassandra.apache.org/job/Cassandra-trunk/1074/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[11:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1073/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[09:09|https://ci-cassandra.apache.org/job/Cassandra-trunk/1072/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[15:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1070/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[10:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1069/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[10:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1068/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[06:17|https://ci-cassandra.apache.org/job/Cassandra-trunk/1067/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[03:53|https://ci-cassandra.apache.org/job/Cassandra-trunk/1066/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[15:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1065/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[04:33|https://ci-cassandra.apache.org/job/Cassandra-trunk/1064/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|

I think there is nothing wrong with having a test that takes long because it 
evaluates many parameters, so we could just further increase the value of 
[{{test.distributed.timeout}}|https://github.com/apache/cassandra/blob/2fde9af74f12179fd8b3d592adc9a24d8b2d8f23/build.xml#L116].
 Alternatively, we could solomonically split the test into two or more tests. 
[~maedhroz] wdyt?


was (Author: adelapena):
The {{ReadRepairQueryTypesTest}} test suite seems very stable on CircleCI, as 
it's shown by the success of these 1000-iteration runs:
||branch||CI||
|4.0|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1471/workflows/c183b8ac-4a34-4774-865e-4fe85f3aa191]
 
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1471/workflows/d5fd42da-098f-4752-8810-d1063a504850]|
|trunk|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1470/workflows/843f5ceb-f0f8-4b81-8a5d-61e333118ca6]
 
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1470/workflows/21f52bdc-9a1e-4eab-8ae2-e99721d24e57]|

However, it seems that a particularly slow run on Jenkins can hit the config 
limit defined by 
[{{test.distributed.timeout}}|https://github.com/apache/cassandra/blob/2fde9af74f12179fd8b3d592adc9a24d8b2d8f23/build.xml#L116].
 The run times for the the last Jenkins run show great variability, with some 
runs being close to the limit:
||mm:ss||
|[09:26|https://ci-cassandra.apache.org/job/Cassandra-trunk/1074/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[11:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1073/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[09:09|https://ci-cassandra.apache.org/job/Cassandra-trunk/1072/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[15:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1070/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[10:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1069/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[10:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1068/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[06:17|https://ci-cassandra.apache.org/job/Cassandra-trunk/1067/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[03:53|https://ci-cassandra.apache.org/job/Cassandra-trunk/1066/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[15:00|https://ci-cassandra.apache.org/job/Cassandra-trunk/1065/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|
|[04:33|https://ci-cassandra.apache.org/job/Cassandra-trunk/1064/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/]|

I think there is nothing wrong with having a test that takes long because it 
evaluates many parameters, so we could just further increase the value of 
[{{test.distributed.timeout}}|https://github.com/apache/cassandra/blob/2fde9af74f12179fd8b3d592adc9a24d8b2d8f23/build.xml#L116].
 Alternatively, we could solomonically split the test into two or more tests. 
[~maedhroz] wdyt?

> ReadRepairQueryTypesTest.testUnrestrictedQueryOnSkinnyTable[8: strategy=NONE 
> coordinator=1 flush=false paging=false] times out sporadically
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17543
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17543
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/java
>            Reporter: Caleb Rackliffe
>            Priority: Normal
>
> org.apache.cassandra.distributed.test.ReadRepairQueryTypesTest.testUnrestrictedQueryOnSkinnyTable[8:
>  strategy=NONE coordinator=1 flush=false paging=false]
> {noformat}
> Error Message
> Timeout occurred. Please note the time in the report does not reflect the 
> time until the timeout.
> Stacktrace
> junit.framework.AssertionFailedError: Timeout occurred. Please note the time 
> in the report does not reflect the time until the timeout.
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.util.Vector.forEach(Vector.java:1388)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.util.Vector.forEach(Vector.java:1388)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.util.Vector.forEach(Vector.java:1388)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at org.apache.cassandra.anttasks.TestHelper.execute(TestHelper.java:53)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.util.Vector.forEach(Vector.java:1388)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
> See 
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1075/testReport/org.apache.cassandra.distributed.test/ReadRepairQueryTypesTest/testUnrestrictedQueryOnSkinnyTable_8__strategy_NONE_coordinator_1_flush_false_paging_false_/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to