[
https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525566#comment-17525566
]
Benedict Elliott Smith commented on CASSANDRA-17557:
----------------------------------------------------
Thanks Ekaterina. I think there are two mistakes here in the original patch:
the inclusion of an unnecessary property, and the failure to utilise a
necessary property. The repair rpc timeout was intended to be kept, and
utilised for both standard repair verbs and paxos repair verbs.
I have pushed my suggested variation on this patch
[here|https://github.com/belliottsmith/cassandra/commits/17557-trunk]
> Fix a few config parameters after the Paxos improvements commit
> ---------------------------------------------------------------
>
> Key: CASSANDRA-17557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17557
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> After committing the Paxos improvements, it was identified that the following
> configuration parameters need additional work:
> * repair_request_timeout_in_ms - can be removed
> * paxos_auto_repair_threshold_mb - I think it can be also removed; to be
> confirmed with the author
> Discussed a bit in Slack and on this PR -
> https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
