[ 
https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529521#comment-17529521
 ] 

Blake Eggleston commented on CASSANDRA-17557:
---------------------------------------------

Gave this a look at Benedict's request. Everything looks fine except for the 
change to read repair timeouts. Since those are part of a client query, and 
aren't part of any repair process as intended by this patch, I think they 
should be reverted to writeTimeout.

> Fix a few config parameters after the Paxos improvements commit
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-17557
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17557
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Config
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.1
>
>
> After committing the Paxos improvements, it was identified that the following 
> configuration parameters need additional work:
>  * repair_request_timeout_in_ms - can be removed
>  * paxos_auto_repair_threshold_mb - I think it can be also removed; to be 
> confirmed with the author
> Discussed a bit in Slack and on this PR - 
> https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to