[ https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555049#comment-17555049 ]
Stefan Miklosovic commented on CASSANDRA-15968: ----------------------------------------------- This ticket was inactive so long that we dropped 2.x support so I will not provide patch for that. There was also some work already done in this regard in CASSANDRA-15935 so this patch just builds on top of that. I have rewritten it to use volatile boolean and synchronized methods instead of atomic boolean as suggested by [~yifanc] here (1). I am providing 3.0 and 4.0 branches for review, I assume that 3.11 will be just same stuff as for 3.0 and 4.1 and trunk same as for 4.0. 4.0 [https://github.com/apache/cassandra/pull/1687] 3.0 [https://github.com/apache/cassandra/pull/1688] (1) [https://github.com/dcapwell/cassandra/commit/a4f6e019fa36c18d620a759313d078c902a5e745#commitcomment-40953541] Would somebody from you guys, [~jmeredithco] [~dcapwell] [~yifanc] do a review so I can deliver all branches and builds? > nodetool drain fails in jvm dtest > --------------------------------- > > Key: CASSANDRA-15968 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15968 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java > Reporter: David Capwell > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x > > > Drain fails since MessagingService doesn’t expect to be shutdown twice. > {code} > Caused by: java.lang.AssertionError > at > org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766) > at > org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > ... 3 more > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org