[
https://issues.apache.org/jira/browse/CASSANDRA-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566849#comment-17566849
]
Paulo Motta commented on CASSANDRA-16911:
-----------------------------------------
Looks good to me. I just added one minor comment in the PR to extract
duplicated scrubbing logic to {{CassandraDaemon.scrubDataDirectories}}, to
avoid issues if there's ever a change to this logic.
After that minor fix, feel free to commit after a green CI.
> Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-16911
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16911
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.2
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> While creating an ephemeral snapshot, a marker file is created at disk in a
> respective snapshot directory. This is not necessary anymore as we have
> introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag
> there. By putting the information if a snapshot is ephemeral or not into
> SnapshotManifest, we simplify and "clean up" the snapshotting process and
> related codebase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
