[
https://issues.apache.org/jira/browse/CASSANDRA-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574249#comment-17574249
]
Ekaterina Dimitrova commented on CASSANDRA-17677:
-------------------------------------------------
For the record, we had an off-line discussion that the best approach would be
to have the streaming parameters internally handled in bytes. The RateLimiter
accepts them in bytes anyway and this reduces the calculations for the tools
like Nodetool and BulkLoader. That change was done in another ticket so I think
now we can rebase this one and take advantage of the change. It will help us
with precision problems as we don't need anymore to switch between the old
megabits/s unit and MiB/s. Switching from MiB/s and megabits/s to bytes is
neat.
> Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-17677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17677
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
> Reporter: Ekaterina Dimitrova
> Assignee: Francisco Guerrero
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> {{entire_sstable_stream_throughput_outbound and
> entire_sstable_inter_dc_stream_throughput_outbound}} were introduced in
> CASSANDRA-17065.They were added to the LoaderOptions class but they are not
> loaded in BulkLoader as {{throttle}} and {{interDcThrottle are. }}{{As part
> of this ticket we need to fix the BulkLoader, also those properties should be
> advertised as MiB/s, not megabits/s. This was not changed in CASSANDRA-15234
> for the bulk loader because those are not loaded and those variables in
> LoaderOptions are disconnected from the Cassandra config parameters and
> unused at the moment. }}
> It will be good also to update the doc here -
> [https://cassandra.apache.org/doc/latest/cassandra/operating/bulk_loading.html,|https://cassandra.apache.org/doc/latest/cassandra/operating/bulk_loading.html]
> {{and add a test that those are loaded properly when used with the
> BulkLoader. }}
> {{CC [~frankgh] }}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
