[
https://issues.apache.org/jira/browse/CASSANDRA-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579893#comment-17579893
]
Ekaterina Dimitrova commented on CASSANDRA-17677:
-------------------------------------------------
In my humble opinion this looks really good! Docs, tests, etc..
I left only one comment about a description, otherwise I am +1. We need only
CHANGES.txt and NEWS.txt (deprecation section and to explain we have changed
the new flags for entire-stable as this is not compatible with alpha1 version)
I think we are only looking for [~yifanc] final comment (I guess he wants to
make final check after the discussions and the latest changes?)
Last but not least, as far as I can tell the patch is the same for 4.1 and
trunk so I reviewed only the 4.1 PR. Please let me know if that was not the
case and there is something in addition I need to look at.
> Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-17677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17677
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
> Reporter: Ekaterina Dimitrova
> Assignee: Francisco Guerrero
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> {{entire_sstable_stream_throughput_outbound and
> entire_sstable_inter_dc_stream_throughput_outbound}} were introduced in
> CASSANDRA-17065.They were added to the LoaderOptions class but they are not
> loaded in BulkLoader as {{throttle}} and {{interDcThrottle are. }}{{As part
> of this ticket we need to fix the BulkLoader, also those properties should be
> advertised as MiB/s, not megabits/s. This was not changed in CASSANDRA-15234
> for the bulk loader because those are not loaded and those variables in
> LoaderOptions are disconnected from the Cassandra config parameters and
> unused at the moment. }}
> It will be good also to update the doc here -
> [https://cassandra.apache.org/doc/latest/cassandra/operating/bulk_loading.html,|https://cassandra.apache.org/doc/latest/cassandra/operating/bulk_loading.html]
> {{and add a test that those are loaded properly when used with the
> BulkLoader. }}
> {{CC [~frankgh] }}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
