[ https://issues.apache.org/jira/browse/CASSANDRA-17778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578629#comment-17578629 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17778 at 8/11/22 7:36 PM: -------------------------------------------------------------------------- [~erickramirezau] and [~maedhroz], can you, please, check [this |https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:17778-4.1?expand=1] diff, please? (CI will be run precommit for a sanity check for both 4.1 and trunk but at this point this is what I want to add, hopefully making it more clear what happens) It adds explicit supported units table and a comment on VTs to the config doc; fix the link issue (now the page should be found both from Configuration and the What's new), plus I added a few more sentences and fixes in NEWS.txt to make it hopefully more clear. was (Author: e.dimitrova): [~erickramirezau] and [~maedhroz], can you, please, check [this |https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:17778-4.1?expand=1] diff, please. It adds explicit supported units table and a comment on VTs to the config doc; fix the link issue (now the page should be found both from Configuration and the What's new), plus I added a few more sentences and fixes in NEWS.txt to make it hopefully more clear. > WEBSITE - Add CASSANDRA-15234 config page to Docs nav menu > ---------------------------------------------------------- > > Key: CASSANDRA-17778 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17778 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website > Reporter: Erick Ramirez > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.1.x, 4.x > > > There is no way to navigate to the new configuration page for CASSANDRA-15234 > ([Liberating cassandra.yaml Parameters' Names from Their > Units|https://cassandra.apache.org/doc/trunk/cassandra/new/configuration.html]) > because it is not referenced anywhere. > Unless someone has bookmarked the page, there is no way to find it on the > site. > Other doc changes expected: > * Add a small table with supported units per type as currently we list only > the duration's ones and min units for old parameters. We list the supported > units only in NEWS.txt. > * Add info about the RuntimeExceptions we introduced in CASSANDRA-17725 for > a few deprecated JMX getters. > * Add a note for Cassandra developers - "Please ensure that any JMX > setters/getters update the Config class properties and not some local copies. > Settings Virtual Table reports the configuration loaded at any time from the > Config class." -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org