[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620131#comment-17620131
]
Stefan Miklosovic commented on CASSANDRA-17964:
-----------------------------------------------
I think we are moving in circles so I try to explain that once again.
I indeed wrote that there will be cases when my regexp is not detecting
everything. It will not detect a corner case like "MySplitTest1". This is the
price we pay for having other classes which have "Test" in it. For example,
these are violations with your regexp (bellow).
How do you want to rename FuzzTestBase? To what? Or TestHelper, or
UpgradeTestBase, or AuthTestUtils ... These files do contain "Test" in the
middle but as far as I tried you regexp's correctly, it will mark it to be
invalid. I do not think they should be invalid. These names are just fine.
There will be still a manual process anyway, on PR, to go over PR and we do
detect if some test is called "MyTestForThisFeature". I do not think people are
going to create tests like these anyway from now on. The most frequent
violations are caused by "TestThisFeature" and "MyFeatureTests" my regexp marks
as failure.
{code:java}
TestHelper.java
BurnTestUtil.java
FuzzTestBase.java
DistributedTestSnitch.java
CASCommonTestCases.java
CASTestBase.java
JVMDTestTest.java
PaxosRepairTest2.java
ReprepareTestBase.java
ReprepareTestOldBehaviour.java
TestBaseImpl.java
ConfigCompatabilityTestGenerate.java
MixedModeAvailabilityTestBase.java
MixedModeBatchTestBase.java
MixedModeConsistencyTestBase.java
MixedModeReplicationTestBase.java
UpgradeTestBase.java
TokenAllocatorTestBase.java
ReadTestSmallPartitions.java
ReadTestWidePartitions.java
SimulationTestBase.java
ServerTestUtils.java
AuthTestUtils.java
CassandraAuthorizerTruncatingTests.java
KeywordTestBase.java
KeywordTestSplit1.java
KeywordTestSplit2.java
CDCTestReplayer.java
CommitLogTestReplayer.java
CommitLogUpgradeTestMaker.java
TestMemtable.java
PartitionerTestCase.java
OfflineTokenAllocatorTestUtils.java
DTestSerializer.java
HintsTestUtil.java
SSTableWriterTestBase.java
TestChannel.java
TestScheduledFuture.java
SchemaTestUtil.java
PaxosUncommittedTests.java
TestableReadRepair.java
TableStatsTestBase.java
EncodeAndDecodeTestBase.java
FilterTestHelper.java
KillerForTests.java
AbstractTestAsyncPromise.java
AbstractTestAwaitable.java
AbstractTestPromise.java
{code}
> Some tests are never executed due to naming violation - fix it and add
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
