[ 
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630514#comment-17630514
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17950:
-------------------------------------------------

{quote}I'm afraid formatting has rendered this ilegible, is it "-" and "_", 
right? I'll be fine doing that in a separate ticket.
{quote}
Ops, you are right, that's what it had to be. 
{quote}Also, you'll hate me for this, but can we rename the 
{{j8_cqlsh_dtests_offheap_py3}} jobs to {{{}j8_cqlsh_dtests_py3-offheap{}}}, so 
it's consistent with {{{}j8_cqlsh_dtests_py3_vnode{}}}, where we have first the 
Python version and then the config option? I'll be fine doing that in the 
followup ticket for homogenizing names.
{quote}
No, no hate :D I changed them three times last night... naming is hard. hehe I 
think what you suggested makes sense and it changes the new names so it doesn't 
add noise. I will do that now before the patches.
{quote}Looks good to me, I think we can update the patches and run the other 
resource configs.
{quote}
Thanks. Let's commit CASSANDRA-18024 and I will do them and add test runs. 
Thank you for the quick review.

 

> Enable dtest-offheap in CircleCI
> --------------------------------
>
>                 Key: CASSANDRA-17950
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Test/dtest/python
>            Reporter: Derek Chen-Becker
>            Assignee: Derek Chen-Becker
>            Priority: Normal
>             Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to