[
https://issues.apache.org/jira/browse/CASSANDRA-17950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631036#comment-17631036
]
Andres de la Peña commented on CASSANDRA-17950:
-----------------------------------------------
That's looking good :)
I have tested the patches locally to see that the patches apply cleanly, the
repeated jobs are removed on the absence on tests to be repeated, etc. All
looks good to me to the extent that, as we know, it's a quite manual process. I
hope not to have missed anything.
I see that on pre-commit offheap cqlsh dtests are optional, whereas regular and
vnodes cqlsh dtests are mandatory, which is ok to me. However, it's a bit odd
that on the separate workflows there is a separate approval step for offheap
cqlsh dtests, whereas regular and vnodes cqlsh dtests are grouped together
under a single approval step. I think we should probably have either a single
approval step for all types of cqlsh dtests, or three separate approval steps
for regular, vnodes and offheap cqlsh dtests. Since that would be just a very
minor improvement we can do it in a separate ticket, and keep going with this
as it is so we get to CI parity as soon as possible.
> Enable dtest-offheap in CircleCI
> --------------------------------
>
> Key: CASSANDRA-17950
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17950
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
> Reporter: Derek Chen-Becker
> Assignee: Derek Chen-Becker
> Priority: Normal
> Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
