[ 
https://issues.apache.org/jira/browse/CASSANDRA-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644968#comment-17644968
 ] 

Paulo Motta commented on CASSANDRA-18102:
-----------------------------------------

{quote}If snapshots in memory and on disk get unsynchronized, there should be a 
way how to sync it again. I propose new flag in nodetool listsnaphot (like -r / 
--refresh). That would go to disk, by default it would read from 
SnapshotManager.
{quote}
I don't think snapshots in memory and disk should ever get unsynchronized, so I 
don't think we need such flag. We just need to ensure any created or removed 
snapshots are reflected in {{SnapshotManager}}.

The work of unifying snapshot management on {{SnapshotManager}} on [this 
branch|https://github.com/apache/cassandra/pull/1305] moves snapshots to 
memory, with tests. We just need to rebase the branch and remove stuff that was 
committed as part of CASSANDRA-17588.

> Add a virtual table to list snapshots
> -------------------------------------
>
>                 Key: CASSANDRA-18102
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18102
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables, Local/Snapshots
>            Reporter: Paulo Motta
>            Assignee: maxwellguo
>            Priority: Normal
>
> It should be possible to query a node's snapshots via virtual tables.
> The table should expose the same fields/columns as the 
> [TableSnapshot|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java]
>  class.
> Something along these lines:
> {noformat}
> cqlsh> SELECT * FROM system_views.snapshots;
>  
> tag | keyspace_name | table_name |  table_id | is_ephemeral | created_at | 
> expires_at | directories
> ----+---------------+------------+-----------+--------------+-----------+------------+------------
> 1670460346841 | system | compaction_info | 
> 123e4567-e89b-12d3-a456-426614174000 | false | 2022-12-08T00:45:47.108Z | 
> null | 
> {'/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/snapshots/1670460346841'}
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to