[ 
https://issues.apache.org/jira/browse/CASSANDRA-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644977#comment-17644977
 ] 

Paulo Motta commented on CASSANDRA-18102:
-----------------------------------------

bq. Yes, manual removal of a snapshot from disk by negligent or uninformed 
user, even done by accident, would make it unsynchronised.

We can add logic to check that the snapshot is present on disk before returning 
from {{SnapshotManager}}, I think this is done by the 
{{TableSnapshot.exists()}} method. We just need to remove it from 
{{SnapshotManager}} and maybe log a warning.

> Add a virtual table to list snapshots
> -------------------------------------
>
>                 Key: CASSANDRA-18102
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18102
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables, Local/Snapshots
>            Reporter: Paulo Motta
>            Assignee: maxwellguo
>            Priority: Normal
>
> It should be possible to query a node's snapshots via virtual tables.
> The table should expose the same fields/columns as the 
> [TableSnapshot|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java]
>  class.
> Something along these lines:
> {noformat}
> cqlsh> SELECT * FROM system_views.snapshots;
>  
> tag | keyspace_name | table_name |  table_id | is_ephemeral | created_at | 
> expires_at | directories
> ----+---------------+------------+-----------+--------------+-----------+------------+------------
> 1670460346841 | system | compaction_info | 
> 123e4567-e89b-12d3-a456-426614174000 | false | 2022-12-08T00:45:47.108Z | 
> null | 
> {'/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/snapshots/1670460346841'}
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to