[
https://issues.apache.org/jira/browse/CASSANDRA-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648654#comment-17648654
]
Stefan Miklosovic edited comment on CASSANDRA-18061 at 12/16/22 2:32 PM:
-------------------------------------------------------------------------
[~maxwellguo] I have fixed more things in this commit (1). Please include that
commit into your branch.
Some tests are failing in CompactionHistoryTest because you do not check the
result of `anyMatch` in compactionHistoryResultVerify method. When I check that
it returns true, it fails. Please fix these tests.
Thank you.
(1)
https://github.com/instaclustr/cassandra/commit/e4f5c2adfa89c5431a05bf8836975c87eb70023c
was (Author: smiklosovic):
[~maxwellguo] I have fixed more things in this commit (1). Please include that
commit into your branch.
Some tests are failing in CompactionHistoryTest because you do not check the
result of `anyMatch` in compactionHistoryResultVerify method. When I check that
it returns true, it fails. Please fix these tests.
Thank you.
(1)
https://github.com/instaclustr/cassandra/commit/f71afd10a3d6a3e21b427165252b66d9be23ae50
> Add compaction type output result for nodetool compactionhistory
> ----------------------------------------------------------------
>
> Key: CASSANDRA-18061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18061
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction, Tool/nodetool
> Reporter: maxwellguo
> Assignee: maxwellguo
> Priority: Low
> Fix For: 4.x
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> If we want to see whether we have made a compaction and what kind of
> compaction we have done for this node, we may go to see the
> compaction_history system table for some deftails or use nodetool
> compactionhistory command , But I found that the table do not specify the
> compaction type so does the compactionhistory command too, like index build ,
> compaction type, clean or scrub for this node. So I think may be it is need
> to add a type of compaction column to specify the compaction tpe for
> system.compaction_history and so we can get the type of compaction through
> system.compaction_history table or nodetool compactionhistory to see whether
> we have made a major compact for this node .:)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
