[ https://issues.apache.org/jira/browse/CASSANDRA-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17672301#comment-17672301 ]
maxwellguo edited comment on CASSANDRA-18061 at 1/11/23 10:33 AM: ------------------------------------------------------------------ Thanks [~jlewandowski] , [~smiklosovic] can you help to see the comments ? [~jlewandowski]after read your comment , My question is , it seems that every time we modify the system table(I mean just add some columns) , a SystemKeyspaceMigrator will need to add the modified table . But there is so much system table, so some times a column is added , a V2 table should be created and doing some migrate.There may be V2 /V3 /V4 ,so much verisions plus the huge number of system table, there will be much system table in the process.... In SystemKeyspaceMigrator41 I saw that only the schema changed (primary key is changed), then a migrate will be added. [~brandon.williams] can you help to give some advice on this too ? Thank you . I think it is a good idea to make the newly added column as a type of map (y) was (Author: maxwellguo): Thanks [~jlewandowski] , [~smiklosovic] can you help to see the comments ? [~jlewandowski]after read your comment , My question is , it seems that every time we modify the system table(I mean just add some columns) , a SystemKeyspaceMigrator will need to add the modified table . But there is so much system table, so some times a column is added , a V2 table should be created and doing some migrate.There may be V2 /V3 /V4 ,so much verisions plus the huge number of system table, there will be much system table in the process.... In SystemKeyspaceMigrator41 I saw that only the schema changed (primary key is changed), then a migrate will be added. I think it is a good idea to make the newly added column as a type of map (y) > Add compaction type output result for nodetool compactionhistory > ---------------------------------------------------------------- > > Key: CASSANDRA-18061 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18061 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Tool/nodetool > Reporter: maxwellguo > Assignee: maxwellguo > Priority: Low > Fix For: 4.x > > Time Spent: 3h > Remaining Estimate: 0h > > If we want to see whether we have made a compaction and what kind of > compaction we have done for this node, we may go to see the > compaction_history system table for some deftails or use nodetool > compactionhistory command , But I found that the table do not specify the > compaction type so does the compactionhistory command too, like index build , > compaction type, clean or scrub for this node. So I think may be it is need > to add a type of compaction column to specify the compaction tpe for > system.compaction_history and so we can get the type of compaction through > system.compaction_history table or nodetool compactionhistory to see whether > we have made a major compact for this node .:) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org