[ 
https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656316#comment-17656316
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18139:
-------------------------------------------------

I agree with your points. On the other hand after CASSANDRA-18139 I made some 
effort to get back and revert other units changes in nodetool output with the 
support of other community members, FileUtils#stringifyFileSize was an honest 
miss so if we revert in theory we should be consistent with the current 
nodetool state which should still have the old format of units in output. 

The reason I suggest a flag is for people who might have been using it in 4.1.0 
already so they can switch to it at least. On the other hand flag or not we 
will break those people in a patch release. Not sure how many are those with 
new clusters using already that output though... considering we just released 
before Christmas. I am wondering if it makes sense to hit the dev and/or user 
list to gather some more feedback from people before moving forward one way or 
another. 

> Revert changes to units output in FileUtils#stringifyFileSize post 
> CASSANDRA-15234
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18139
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18139
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Ekaterina Dimitrova
>            Priority: Normal
>
> As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in 
> nodetool output which can break people parsing the nodetool output



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to