[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679240#comment-17679240 ]
Ekaterina Dimitrova commented on CASSANDRA-18139: ------------------------------------------------- Oh wait, we didn't change the printed units in CASSANDRA-15234! They were already printed as TiB, MiB, etc changed in CASSANDRA-9692. Those are printed that way since 3.6.... We changed in [this|https://github.com/apache/cassandra/commit/1315d0c96f4625a76296f58d431f97669e5178c2] and [this|https://github.com/apache/cassandra/commit/23138252f20891c26a3692664c6affaf99e86541] commits the constants ONE_KB to ONE_KIB etc. I do not believe that this is considered a breaking change, is it? We didn't change the nodetool output? [~ifesdjeen] did you actually refer to the constants? Is FileUtils considered API that will be used by tools? Is this documented? What do I miss? > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > ---------------------------------------------------------------------------------- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug > Components: Local/Config > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.x > > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org