[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677309#comment-17677309
]
Stefan Miklosovic edited comment on CASSANDRA-17964 at 1/16/23 10:36 AM:
-------------------------------------------------------------------------
I would Ignore failing tests (but I would still rename them), examples will be
renamed too. Then I would dedicate separate ticket to un-ignore them and fix
them. I do not think fixing these tests is the scope of this ticket. I agree
that we might keep ant tasks sources tracked.
great we are on the same page, lets deliver this!
was (Author: smiklosovic):
I would Ignore failing tests (but I would still rename them), examples will be
renamed too. Then I would dedicate separate ticket to un-ignore them and fix
them. I do not think fixing these tests is the scope of this ticket. I agree
that we might keep ant tasks sources tracked.
[~bereng] does this sound good to you? We would get rid of that annotation as
you suggested.
> Some tests are never executed due to naming violation - fix it and add
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
