[
https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679632#comment-17679632
]
Ekaterina Dimitrova edited comment on CASSANDRA-17964 at 1/22/23 7:28 PM:
--------------------------------------------------------------------------
bq. I am becoming a little bit irritated by this ticket already. I am
constantly waiting for something to happen and people changing their minds on
the last notice.
Last thing I want is to irritate you or demand anything. The opposite - I want
to thank you guys for tackling this problem!
bq. Because the work in this ticket has nothing to do with them failing. It is
about introducing an Ant task and respective target which is checking how they
are called, not if they are run successfully.
Totally agree with you
I also did not have the intention to imply that you should fix those tests. Not
at all! You solved the problem in hand. That those tests failed with no one
realizing that because they were not run is not part of the problem you are
solving here. More like - I was wondering what is the rationality to add
@ignore if we are opening tickets and they need to be fixed? Same as every
other ticket we have for failing/flaky test. That's all I meant. I was
wondering whether they are maybe just too many and you don't want to add too
much noise or so?
was (Author: e.dimitrova):
bq. I am becoming a little bit irritated by this ticket already. I am
constantly waiting for something to happen and people changing their minds on
the last notice.
Last thing I want is to irritate you or demand anything. The opposite - I want
to thank you guys for tackling this problem!
bq. Because the work in this ticket has nothing to do with them failing. It is
about introducing an Ant task and respective target which is checking how they
are called, not if they are run successfully.
Totally agree with you
I also did not have the intention to imply that you should fix those tests. Not
at all! You solved the problem in hand. That those tests failed with no one
realizing that because they were not run is not part of the problem you are
solving here. More like - I was wondering what is the rationality to add
@ignore if we are opening tickets and they need to be fixed? Same as every
other ticket we have for failing/flaky test. That's all I meant.
> Some tests are never executed due to naming violation - fix it and add
> checkstyle where applicable
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17964
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17964
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java]
> doesn't follow naming convention to be run as unit tests and, thus, is never
> run.
> The rule in build expects names as `*Test`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
