[ 
https://issues.apache.org/jira/browse/CASSANDRA-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683216#comment-17683216
 ] 

Brad Schoening commented on CASSANDRA-18219:
--------------------------------------------

[~smiklosovic] Thanks for the lightning fast fix! Yes, by DEBUG level I was 
referring to the NoSpamLogger which writes to debug.log.
INFO  [ScheduledTasks:1] 2016-08-10 16:56:50,209 NoSpamLogger.java:91 - Some 
operations were slow, details available at debug level (debug.log)
This issue is only about cassandra.log and debug.log, not CQLSH.  

To be most useful, the NoSpamLogger would log the CQL query text, not just 
repeat what WARN already logs. I.e. in <...>:
DEBUG [ScheduledTasks:1] 2016-08-10 16:56:50,211 MonitoringTask.java:173 - 3 
operations were slow in the last 4998 msecs:
<SELECT * FROM ks.test2 LIMIT 5000>, time 3026 msec - slow timeout 30 msec
<SELECT * FROM ks.test2 WHERE id = 1 LIMIT 5000>, was slow 2 times: avg/min/max 
330/325/335 msec - slow timeout 30 msec
<SELECT * FROM ks.test2 WHERE token(id) > 0 LIMIT 5000>, time 1449 msec - slow 
timeout 30 msec

> Warning message on aggregation queries doesn't specify table name or 
> aggregate type
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18219
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18219
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Logging
>            Reporter: Brad Schoening
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The existing aggregation query warning messages in cassandra.log from 
> SelectStatement.java:
>      _'[WARN] Aggregation query used without partition key'_
>      {_}'{_}{_}[WARN]{_} _Aggregation query used on multiple partition keys 
> (IN restriction)'_
> are missing the helpful details which would assist users in quickly 
> identifying the offending query. The table name and type of aggregation would 
> be useful additions in the WARN message.
> In addition, following the example of the slow query logger and printing out 
> the query string at DEBUG level would be especially helpful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to