[ 
https://issues.apache.org/jira/browse/CASSANDRA-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683334#comment-17683334
 ] 

Benjamin Lerer commented on CASSANDRA-18219:
--------------------------------------------

The idea behind the warn is to send the warning back to the client performing 
the query. Of course they can choose to ignore it which is why we also log the 
message to the logs.
Adding the table name make total sense from the log point of view.
[~bschoeni] I imagine that if you want to find the problematic query your 
intention is to ask the user to stop running that query. Would it not make 
sense at this point to had some Guardrails to block those queries rather than 
introducing more logging?

> Warning message on aggregation queries doesn't specify table name or 
> aggregate type
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18219
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18219
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Logging
>            Reporter: Brad Schoening
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The existing aggregation query warning messages in cassandra.log from 
> SelectStatement.java:
>      _'[WARN] Aggregation query used without partition key'_
>      {_}'{_}{_}[WARN]{_} _Aggregation query used on multiple partition keys 
> (IN restriction)'_
> are missing the helpful details which would assist users in quickly 
> identifying the offending query. The table name and type of aggregation would 
> be useful additions in the WARN message.
> In addition, following the example of the slow query logger and printing out 
> the query string at DEBUG level would be especially helpful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to