[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734474#comment-17734474
]
Stefan Miklosovic commented on CASSANDRA-18305:
-----------------------------------------------
The build failed because our dtests are using this method (1) which is waiting
for an output which never happens as we changed it. It is without semicolon and
alignment is different as well.
We either fix this directly in ccm (that is rather tricky / too much work with
the release etc) or we just fix this in the tests.
{code}
$ find . -type f -name '*.py' | grep -v './src/' | grep -v './lib/' | grep -v
'./venv/' | xargs grep wait_for_compactions
./offline_tools_test.py: self.wait_for_compactions(node1)
./offline_tools_test.py: def wait_for_compactions(self, node):
./offline_tools_test.py: self.wait_for_compactions(node1)
./repair_tests/incremental_repair_test.py:
cluster.wait_for_compactions()
./repair_tests/incremental_repair_test.py: cluster.wait_for_compactions()
./compaction_test.py: node1.wait_for_compactions()
./compaction_test.py: node1.wait_for_compactions()
./compaction_test.py: node1.wait_for_compactions()
./sstableutil_test.py: node.wait_for_compactions()
./secondary_indexes_test.py: cluster.wait_for_compactions()
./secondary_indexes_test.py: cluster.wait_for_compactions()
./disk_balance_test.py: node.wait_for_compactions()
./disk_balance_test.py: node.wait_for_compactions()
{code}
The approach I came up with is this (2)
Basically, I changed the regexp to optionally include semicolon, then some
spaces (does not matter how many) and then "0". This should be backward
compatible with all previous versions. I have also changed all places where
this check is done by extracting the method to dtest.py
branch 4.0 https://github.com/instaclustr/cassandra/tree/CASSANDRA-18305-4.0
j8 pre-commit
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2477/workflows/311d0d13-5e8a-42f5-aa64-7f294456ef6b
j11 pre-commit
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2477/workflows/3b2c582d-d259-4227-88e9-06b67be18d09
I ll provide other builds if this is agreed on.
BTW do we really want to see this in 4.1 and trunk? I would go with trunk only.
(1) https://github.com/riptano/ccm/blob/master/ccmlib/node.py#L981
(2) https://github.com/smiklosovic/cassandra-dtest/tree/CASSANDRA-18305
> Enhance nodetool compactionstats with existing MBean metrics
> ------------------------------------------------------------
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Brad Schoening
> Assignee: Manish Ghildiyal
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured, perhaps simply add to existing 'pending tasks' line:
> {quote}4 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
