[
https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738455#comment-17738455
]
Jacek Lewandowski commented on CASSANDRA-17909:
-----------------------------------------------
As I can see we do not need that {{sync}} method at all. It is used only in one
test and in this case we can just do something like:
{code}
if (!SyncUtils.SKIP_SYNC)
fd.sync();
{code}
All reflection based hacks can be dropped then :)
> Clean SyncUtil from dead code and update it for new JDK versions
> ----------------------------------------------------------------
>
> Key: CASSANDRA-17909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17909
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> During code inspection I noticed [dead
> code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87]
> (JDK 7) in SyncUtil.
> From a very quick skim _I think_ the [Java 8
> section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75]
> is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at
> least until we have JDK11. To be revisited.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
