[
https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738619#comment-17738619
]
Ekaterina Dimitrova commented on CASSANDRA-17909:
-------------------------------------------------
{quote}It is used only in one test.
{quote}
That was a good catch! Using it in a single test to shred 10 seconds of a
single test (check the original motivation behind creating SyncUtil in
CASSANDRA-9403) does not justify opening internals. On the other hand, syncing
is also not the last operation we do on a file, so if we skip dealing with
SyncFailedException when we do not even sync in the test, it should not be an
issue.
[PR|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:17909-trunk]
was updated accordingly.
Running CI
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17909-trunk],
run #2399
> Clean SyncUtil from dead code and update it for new JDK versions
> ----------------------------------------------------------------
>
> Key: CASSANDRA-17909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17909
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> During code inspection I noticed [dead
> code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87]
> (JDK 7) in SyncUtil.
> From a very quick skim _I think_ the [Java 8
> section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75]
> is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at
> least until we have JDK11. To be revisited.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
