[ 
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751049#comment-17751049
 ] 

Jacek Lewandowski commented on CASSANDRA-17992:
-----------------------------------------------

As I said, I agree we should add that to the dependencies.

What I'm not sure is that whether we should do something with the classpath 
dynamically. Netty 4.1.58 which we used before included that dependency for all 
possible platforms: 
https://search.maven.org/artifact/io.netty/netty-all/4.1.58.Final/jar, so 
probably it can be enough to just add those dependencies to the pom.


> Upgrade Netty on 5.0
> --------------------
>
>                 Key: CASSANDRA-17992
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Ekaterina Dimitrova
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 5.0
>
>         Attachments: important-netty-inter-releases.md, 
> netty-release-notes-filtered.md, netty-release-notes.md
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I haven't been able to identify from the Netty docs which was the lowest 
> version where JDK17 was added but we are about 40 versions behind in netty 4 
> so I suspect we better update. 
> -We need to consider there was an issue with class cast exceptions when 
> building with JDK17 with newer versions of netty (the newest available in 
> March 2022). For the record, we didn't see those when running CI on JDK8 and 
> JDK11. We also need to carefully revise the changes between the netty 
> versions. -->- CASSANDRA-18180
> Upgrading will cover also a fix in netty that was discussed in 
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF 
> Slack thread. 
> CC [~benedict] , [~aleksey] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to