[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758115#comment-17758115 ]
Maxim Muzafarov commented on CASSANDRA-14667: --------------------------------------------- [~e.dimitrova] I checkouted the java-driver repo, prepared a new driver version with the above changes, and tested everything locally. I was not able to run all of the dtest on CI, but the tests that I saw failed due to missing classes in the classpath, they started to pass. Changes here (without the driver upgrade) also work, but with shading metrics in the driver itself we don't need to copy the required classes from the metrics library and 3.11.5 will reduce the cassandra-related patch up to ~10-20 lines of code (if we have 3.11.5 we won't need to copy missing classes and won't need to use withoutMetrics()) which seems to be the correct way to go. https://github.com/apache/cassandra/pull/2238 > Upgrade Dropwizard Metrics to 4.x > --------------------------------- > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics > Reporter: Stig Rohde Døssing > Assignee: Maxim Muzafarov > Priority: Normal > Fix For: 5.x > > Attachments: signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org