[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764129#comment-17764129
]
Maxim Muzafarov commented on CASSANDRA-14667:
---------------------------------------------
So, I've checked the results. The good news is that our approach to shade the
dropwizard metrics in the java driver itself works. All the dtests that were
previously failed now pass and in general everything looks good (the
{{test_failing_manual_rebuild_index}} is here CASSANDRA-18361 ). The bad news
is that there were some unit tests that had a hardcoded version of the java
driver we were using, so a tiny fix was needed to make them work. I've pushed
the fix to the branch
I was thinking that we could read the driver version from the pom and push the
version to junit tests, when realized that it increases the complexity of the
version upgrade patch and it is probably better to do this in another issue if
we want to.
> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
> Reporter: Stig Rohde Døssing
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
