[ https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793027#comment-17793027 ]
Ekaterina Dimitrova commented on CASSANDRA-18688: ------------------------------------------------- The patch LGTM, tested: JDK11 - start Cassandra, cqlsh, run nodetool JDK17 - start Cassandra, cqlsh, run nodetool JDK21 - start Cassandra when the new environment variable is set. I can only start it when the environment variable is set. However, I think we need to make Cassandra fail to start also when the environment variable is set to false, as shown [here|https://github.com/apache/cassandra/pull/2563#discussion_r1414460296] +1 after addressing that one and testing the packaging in Jenkins when it is back. Thanks! > Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out > of that > ------------------------------------------------------------------------------------ > > Key: CASSANDRA-18688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18688 > Project: Cassandra > Issue Type: Task > Components: Build > Reporter: Ekaterina Dimitrova > Assignee: shylaja kokoori > Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Currently, we limit our users from building with non-default Java versions in > build.xml. > They can easily hack build.xml for test purposes with different versions. > Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit > people to those two, but only to everything >= 11. We should also put an > upper limit of 17 in our Cassandra startup scripts. We can also add a flag to > opt-out if someone wants to test with newer versions. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org