[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799474#comment-17799474
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-------------------------------------------------
{quote} I think with new contributors we should be happy with patches that are
good (where perfect is the enemy).
{quote}
I was perfectly happy with the original -J flag suggestion ;)
With that said, I think it is very important to guide new contributors to
understand the way things work and not rely only on green CI, but do manual
testing when needed, know where and how we test packaging, etc. [~skokoori] did
a great job looking into the details and testing things. Thank you!
+1
> Limit Java runtime in 5.0 to JDK 11 and 17 in scripts; add a flag to opt out
> of that
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18688
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: shylaja kokoori
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently, we limit our users from building with non-default Java versions in
> build.xml.
> They can easily hack build.xml for test purposes with different versions.
> Cassandra–5.0 will be run on JDK11 and JDK17, but on startup, we do not limit
> people to those two, but only to everything >= 11. We should also put an
> upper limit of 17 in our Cassandra startup scripts. We can also add a flag to
> opt-out if someone wants to test with newer versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
