arjunashok commented on code in PR #17:
URL:
https://github.com/apache/cassandra-analytics/pull/17#discussion_r1420965872
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/token/ReplicaAwareFailureHandler.java:
##########
@@ -71,64 +72,138 @@ public void addFailure(Range<BigInteger> tokenRange,
Instance casInstance, Strin
for (Map.Entry<Range<BigInteger>, Multimap<Instance, String>> entry :
overlappingFailures.asMapOfRanges().entrySet())
{
Multimap<Instance, String> newErrorMap =
ArrayListMultimap.create(entry.getValue());
-
newErrorMap.put(casInstance, errMessage);
mappingsToAdd.put(entry.getKey(), newErrorMap);
}
failedRangesMap.putAll(mappingsToAdd);
}
- public boolean hasFailed(ConsistencyLevel consistencyLevel, String localDC)
+ public List<Instance> getFailedInstances()
Review Comment:
Yep, that should be a `Set`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
