arjunashok commented on code in PR #17: URL: https://github.com/apache/cassandra-analytics/pull/17#discussion_r1422015166
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CommitCoordinator.java: ########## @@ -128,61 +128,51 @@ private Stream<ListenableFuture<CommitResult>> commit(Map<RingInstance, Listenin RingInstance instance, Map<String, Range<BigInteger>> uploadRanges) { - if (cluster.instanceIsAvailable(instance)) Review Comment: The expectation is for the instance to be available or transitioning at this point. If the instance does happen to be down, it should result in a commit failure, which is further evaluated against the CL requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org