JeetKunDoug commented on code in PR #45: URL: https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539949686
########## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java: ########## @@ -64,7 +65,6 @@ private CassandraBulkWriterContext(@NotNull BulkSparkConf conf, this.conf = conf; this.clusterInfo = clusterInfo; String lowestCassandraVersion = clusterInfo.getLowestCassandraVersion(); - CassandraBridge bridge = CassandraBridgeFactory.get(lowestCassandraVersion); Review Comment: Mostly a matter of getting the lowest version as late as possible - imagine a mid-upgrade scenario where a node comes back online with a newer version (and it was the last one to be upgraded)... In the grand scheme of things, this is pretty unlikely to happen, and the previous version's libraries will still work, but it seemed worthwhile to allow it to be lazy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org