arjunashok commented on code in PR #51:
URL:
https://github.com/apache/cassandra-analytics/pull/51#discussion_r1581455845
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java:
##########
@@ -217,16 +228,15 @@ private void persist(@NotNull JavaPairRDD<DecoratedKey,
Object[]> sortedRDD, Str
markRestoreJobAsSucceeded(context);
});
- LOGGER.info("Bulk writer job complete. rows={} bytes={}
cluster_resized={}",
+ LOGGER.info("Bulk writer job complete. rows={} bytes={}
cluster_resize={}",
rowCount,
totalBytesWritten,
hasClusterTopologyChanged);
publishSuccessfulJobStats(rowCount, totalBytesWritten,
hasClusterTopologyChanged);
}
catch (Throwable throwable)
{
- publishFailureJobStats(throwable.getMessage());
Review Comment:
Yes, we are not explicitly publishing failure stats at the point of failure.
Instead, we rely on the job failure event, and the listener now publishes these
stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
