jberragan commented on code in PR #62: URL: https://github.com/apache/cassandra-analytics/pull/62#discussion_r1672861006
########## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/StreamScanner.java: ########## @@ -49,30 +49,31 @@ * <p> * Upon return from the next() call the current values of the scanner can be obtained by calling * the methods in Rid, getPartitionKey(), getColumnName(), getValue(). + * * @param <Type> type of object returned by rid() method. */ @SuppressWarnings("unused") public interface StreamScanner<Type> extends Closeable Review Comment: It is somewhat a legacy interface and it's mostly due to the way `AbstractStreamScanner` is implemented, it would be nice to move to a `java.util.Iterator` but nobody has grasped that nettle so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org