jberragan commented on code in PR #62:
URL:
https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674319890
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/EmptyStreamScanner.java:
##########
@@ -24,13 +24,13 @@ public class EmptyStreamScanner implements
StreamScanner<Rid>
public static final EmptyStreamScanner INSTANCE = new EmptyStreamScanner();
@Override
- public Rid rid()
+ public Rid data()
{
return null;
}
@Override
- public boolean hasNext()
+ public boolean next()
Review Comment:
`next()` actually causes the underlying scanner to move it's position which
is not normally the contract for `hasNext()` which is normally expected to be
idempotent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
