[
https://issues.apache.org/jira/browse/CASSANDRA-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135215#comment-13135215
]
Tyler Hobbs commented on CASSANDRA-3388:
----------------------------------------
A couple of comments on v1 of the patch:
* I think you accidentally lower-cased 'Leaving' on one line
* Everything is done consistently now, but I'm a little bit concerned about
this being accidentally broken in the future. Would you mind either splitting
the mode (currently just the string prefix) into a separate parameter or at
least documenting the setMode() method with a note about how it should be used?
Thanks, Sylvain.
> StorageService.setMode() is used inconsistently
> -----------------------------------------------
>
> Key: CASSANDRA-3388
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3388
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Tyler Hobbs
> Priority: Trivial
> Fix For: 1.0.2
>
> Attachments: 3388.patch
>
>
> {{StorageService.setMode()}}, which ends up setting the OperationMode
> attribute of the related mbean, is used inconsistently. In most places, it's
> used like "{{setMode("MODE: details")}}, but in a few places, it's used more
> like a normal log message.
> To make this attribute more usable through JMX, {{setMode()}} should have a
> signature like {{setMode(mode, details)}}, where the mode parameter could be
> an enum (or even just a string, the main thing is just being consistent).
> The OperationMode JMX attribute should definitely remain a string, though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
