[
https://issues.apache.org/jira/browse/CASSANDRA-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lanny Ripple updated CASSANDRA-3450:
------------------------------------
Reviewer: (was: brandon.williams)
Priority: Major (was: Minor)
Description:
1) In {{ColumnFamilyRecordReader}} {{isPredicateEmpty}} needs bracing to
correctly place the {{else if}} to the properly controlling {{if}}.
1a) {{isPredicateEmpty}} should use an || in the getSlice_range predicate
rather than &&.
2) In {{ColumnFamilyRecordReader}} {{computeNext()}} calls {{maybeInit()}} and
then if {{ros}} is not null it is indexed into. {{maybeInit()}} could fetch
new data, determine the associated slice predicate is empty, and end up
removing all the rows if all columns turned out to be empty. There is no check
for {{rows.isEmpty()}} after the possible removal of all rows.
was:
In {{ColumnFamilyRecordReader}} {{computeNext()}} calls {{maybeInit()}} and
then if {{rows}} is not null it is indexed into. {{maybeInit()}} could fetch
new data, determine the associated slice predicate is empty, and end up
removing all the rows if all columns turned out to be empty. There is no check
for {{rows.isEmpty()}} after the possible removal of all rows.
> maybeInit in ColumnFamilyRecordReader can cause rows to be empty but not null
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-3450
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3450
> Project: Cassandra
> Issue Type: Bug
> Components: Hadoop
> Affects Versions: 1.0.1
> Reporter: Lanny Ripple
>
> 1) In {{ColumnFamilyRecordReader}} {{isPredicateEmpty}} needs bracing to
> correctly place the {{else if}} to the properly controlling {{if}}.
> 1a) {{isPredicateEmpty}} should use an || in the getSlice_range predicate
> rather than &&.
> 2) In {{ColumnFamilyRecordReader}} {{computeNext()}} calls {{maybeInit()}}
> and then if {{ros}} is not null it is indexed into. {{maybeInit()}} could
> fetch new data, determine the associated slice predicate is empty, and end up
> removing all the rows if all columns turned out to be empty. There is no
> check for {{rows.isEmpty()}} after the possible removal of all rows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
