[ 
https://issues.apache.org/jira/browse/CASSANDRA-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144470#comment-13144470
 ] 

Hudson commented on CASSANDRA-3450:
-----------------------------------

Integrated in Cassandra-0.8 #393 (See 
[https://builds.apache.org/job/Cassandra-0.8/393/])
    Fix empty row filtering and check if there are no rows returned.
Patch by Lanny Ripple, reviewed by brandonwilliams for CASSANDRA-3450

brandonwilliams : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1197786
Files : 
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* 
/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/hadoop/ColumnFamilyRecordReader.java

                
> maybeInit in ColumnFamilyRecordReader can cause rows to be empty but not null
> -----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3450
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3450
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Hadoop
>    Affects Versions: 0.8.7, 1.0.1
>            Reporter: Lanny Ripple
>            Assignee: Lanny Ripple
>             Fix For: 0.8.8, 1.0.3
>
>         Attachments: v1-0001-CASSANDRA-3450.txt
>
>
> 1) In {{ColumnFamilyRecordReader}} {{isPredicateEmpty}} needs bracing to 
> correctly place the {{else if}} to the properly controlling {{if}}.
> 1a) {{isPredicateEmpty}} should use an || in the getSlice_range predicate 
> rather than &&.
> 2) In {{ColumnFamilyRecordReader}} {{computeNext()}} calls {{maybeInit()}} 
> and then if {{ros}} is not null it is indexed into.  {{maybeInit()}} could 
> fetch new data, determine the associated slice predicate is empty, and end up 
> removing all the rows if all columns turned out to be empty.  There is no 
> check for {{rows.isEmpty()}} after the possible removal of all rows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to