[ 
https://issues.apache.org/jira/browse/CASSANDRA-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143863#comment-13143863
 ] 

Pavel Yaskevich commented on CASSANDRA-2749:
--------------------------------------------

v3 looks good (needs rebase), here is my comments:

 - DatabaseDescriptor.getPerCFDirectory() should be renamed to something like 
"useSeparateCFDirectories"
 - in the ColumnFamilyStory.accept method file name should be checked depending 
on case because we can CF names are case-sensitive.
 - we don't have ColumnFamilyStore.rename method anymore which is a good thing 
for this patch, you can just rebase and remove related code.
 - in the Table.snapshotExists I think we should be more careful determining if 
snapshot actually exists.
 - TODO should be cleaned up.

Wish: if it's possible I think we can remove ColumnFamily name from the SSTable 
files if those are in the CF directory already.

I think we are almost done in here.
                
> fine-grained control over data directories
> ------------------------------------------
>
>                 Key: CASSANDRA-2749
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2749
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Marcus Eriksson
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: 
> 0001-Make-it-possible-to-put-column-families-in-subdirect.patch, 
> 2749_backwards_compatible_v1.patch, 2749_backwards_compatible_v2.patch, 
> 2749_backwards_compatible_v3.patch
>
>
> Currently Cassandra supports multiple data directories but no way to control 
> what sstables are placed where. Particularly for systems with mixed SSDs and 
> rotational disks, it would be nice to pin frequently accessed columnfamilies 
> to the SSDs.
> Postgresql does this with tablespaces 
> (http://www.postgresql.org/docs/9.0/static/manage-ag-tablespaces.html) but we 
> should probably avoid using that name because of confusing similarity to 
> "keyspaces."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to