[ 
https://issues.apache.org/jira/browse/CASSANDRA-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153620#comment-13153620
 ] 

Pavel Yaskevich commented on CASSANDRA-2749:
--------------------------------------------

Thanks a lot for taking care about this, Marcus!

I have tested your latest patch using stress and sstablemover and then stress 
(+ flush/scrub/snapshot) again for Standard (+ secondary indexes) and Super 
ColumnFamilies and everything worked just fine for me. Here are my last 
comments and I think after this gets done we are ready to push your changes:

1). a). Tool should be made more user-friendly by adding at least --help and 
add an option to move sstables back to the keyspace directory (as we have an 
two states in the config);
    b). I think it should delete old sstables after copy automatically or by 
asking user using --delete-old option?
    c). Move sstablemover tool the ./bin instead of ./tools/sstablemover.

2). LegacySSTableTest fails on my machine can you, please, check that?

3). I think we should extend comment in the config describing what should be 
done before it is safe to change to change the option e.g. "Note: before 
setting this option to 'true' you should move existing SSTable files to the 
separate directories manually by using ./bin/sstablemover tool, the same 
applies for 'false' state - ./bin/sstablemover could be used to restore 
original directory structure (Please use ./bin/sstablemover --help for help and 
information)."...  
 
Also please remove/implement remaining // TODO: comments.

                
> fine-grained control over data directories
> ------------------------------------------
>
>                 Key: CASSANDRA-2749
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2749
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: 
> 0001-Make-it-possible-to-put-column-families-in-subdirect.patch, 
> 0001-non-backwards-compatible-patch-for-2749-putting-cfs-.patch.gz, 
> 2749.tar.gz, 2749_backwards_compatible_v1.patch, 
> 2749_backwards_compatible_v2.patch, 2749_backwards_compatible_v3.patch, 
> 2749_backwards_compatible_v4.patch, 2749_backwards_compatible_v4_rebase1.patch
>
>
> Currently Cassandra supports multiple data directories but no way to control 
> what sstables are placed where. Particularly for systems with mixed SSDs and 
> rotational disks, it would be nice to pin frequently accessed columnfamilies 
> to the SSDs.
> Postgresql does this with tablespaces 
> (http://www.postgresql.org/docs/9.0/static/manage-ag-tablespaces.html) but we 
> should probably avoid using that name because of confusing similarity to 
> "keyspaces."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to