[
https://issues.apache.org/jira/browse/CASSANDRA-20913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18023260#comment-18023260
]
Stefan Miklosovic commented on CASSANDRA-20913:
-----------------------------------------------
[~anaik] there is test failure you have introduced in the very test results you
have uploaded.
The failing test class is GuardrailTablePropertiesTest
{code}
junit.framework.AssertionFailedError:
Expecting message to be:
"Invalid value for table_properties_warned: '[invalid]' do not parse as valid
table properties"
but was:
"Invalid values for table_properties_warned: '[invalid]' do not parse as valid
table properties"
Throwable that failed the check:
java.lang.IllegalArgumentException: Invalid values for table_properties_warned:
'[invalid]' do not parse as valid table properties
at
org.apache.cassandra.config.GuardrailsOptions.validateTableProperties(GuardrailsOptions.java:1474)
at
org.apache.cassandra.config.GuardrailsOptions.setTablePropertiesWarned(GuardrailsOptions.java:340)
at
org.apache.cassandra.db.guardrails.Guardrails.setTablePropertiesWarned(Guardrails.java:793)
at
org.apache.cassandra.db.guardrails.GuardrailTester.lambda$assertInvalidProperty$0(GuardrailTester.java:180)
at org.assertj.core.api.ThrowableAssert.catchThrowable(ThrowableAssert.java:63)
at
org.assertj.core.api.AssertionsForClassTypes.catchThrowable(AssertionsForClassTypes.java:892)
at org.assertj.core.api.Assertions.catchThrowable(Assertions.java:1366)
at org.assertj.core.api.Assertions.assertThatThrownBy(Assertions.java:1210)
at
org.apache.cassandra.db.guardrails.GuardrailTester.assertInvalidProperty(GuardrailTester.java:180)
at
org.apache.cassandra.db.guardrails.GuardrailTablePropertiesTest.assertInvalidProperty(GuardrailTableProper
{code}
> Add DDL Guardrail enabling administrators to disallow creation/modification
> of key spaces with durable_writes = false
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-20913
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20913
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Feature/Guardrails, Local/Commit Log
> Reporter: Aparna Naik
> Assignee: Aparna Naik
> Priority: Normal
> Fix For: 6.x
>
> Attachments: ci_summary.html, result_details.tar.gz
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This change implements a guardrail to disallow creation or alteration of key
> spaces to set the property durable_writes = false; durable_writes = true or
> unset should be the only allowable options for this property when enabled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
